Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection failure when using non-standard HTTP port #90

Open
TheRealMintd opened this issue Dec 20, 2021 · 0 comments
Open

Connection failure when using non-standard HTTP port #90

TheRealMintd opened this issue Dec 20, 2021 · 0 comments

Comments

@TheRealMintd
Copy link

TheRealMintd commented Dec 20, 2021

To start, I'm using this library along with the adafruit_espatcontrol library. When using a URL such as http://example.com:8000/, the error RuntimeError: Connection type must be TCP, UDL or SSL is raised.

I think this happens because the conntype parameter is left empty during the _get_socket call, which results in the socket determining the type of the connection based on the port alone.

Since this library knows whether the request is using HTTP or HTTPS, maybe the conntype can be passed directly to the function based on that. Unfortunately, the adafruit_esp32spi library seems to use a completely different way of describing the conntype, which might make passing it problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant