From 155ad5dec445ea4bea6afee87811beec85b3ec87 Mon Sep 17 00:00:00 2001 From: Trond Bergquist Date: Mon, 11 Oct 2021 09:27:52 +0200 Subject: [PATCH] eslint-config: delete dropped rules from jest-eslint-config rename renamed rules. Set new rule require-hook to OFF --- src/eslint-config-adeira/CHANGELOG.md | 10 ++++++++++ .../__tests__/__snapshots__/index.test.js.snap | 12 ++++-------- .../__tests__/__snapshots__/presets.test.js.snap | 10 +++------- src/eslint-config-adeira/src/presets/jest.js | 10 +++------- 4 files changed, 20 insertions(+), 22 deletions(-) diff --git a/src/eslint-config-adeira/CHANGELOG.md b/src/eslint-config-adeira/CHANGELOG.md index 1dc7aef0e4..f289662d74 100644 --- a/src/eslint-config-adeira/CHANGELOG.md +++ b/src/eslint-config-adeira/CHANGELOG.md @@ -1,5 +1,15 @@ # Unreleased +- Delete dropped rules from [`eslint-plugin-jest`](https://github.com/jest-community/eslint-plugin-jest) + - prefer-to-be-undefined + - prefer-to-be-null + - no-expect-resolves + - no-truthy-falsy + - no-try-expect + - prefer-inline-snapshots +- Rename renamed rules from [`eslint-plugin-jest`](https://github.com/jest-community/eslint-plugin-jest) + - valid-describe to valid-describe-callback + - lowercase-name to prefer-lowercase-title - Additional rules from [`eslint-plugin-testing-library`](https://github.com/testing-library/eslint-plugin-testing-library) were enabled (warnings or errors in strict mode). # 6.6.0 diff --git a/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap b/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap index 0ae2b40dac..8ec9e00f00 100644 --- a/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap +++ b/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap @@ -357,7 +357,6 @@ Object { "init-declarations": 0, "jest/consistent-test-it": 0, "jest/expect-expect": 0, - "jest/lowercase-name": 0, "jest/max-nested-describe": Array [ 1, Object { @@ -371,7 +370,6 @@ Object { "jest/no-disabled-tests": 2, "jest/no-done-callback": 0, "jest/no-duplicate-hooks": 2, - "jest/no-expect-resolves": 0, "jest/no-export": 2, "jest/no-focused-tests": 2, "jest/no-hooks": 0, @@ -387,24 +385,22 @@ Object { "jest/no-test-callback": 0, "jest/no-test-prefixes": 0, "jest/no-test-return-statement": 2, - "jest/no-truthy-falsy": 0, "jest/prefer-called-with": 2, "jest/prefer-expect-assertions": 0, "jest/prefer-expect-resolves": 1, "jest/prefer-hooks-on-top": 2, - "jest/prefer-inline-snapshots": 0, + "jest/prefer-lowercase-title": 0, "jest/prefer-spy-on": 0, "jest/prefer-strict-equal": 0, "jest/prefer-to-be": 1, - "jest/prefer-to-be-null": 2, - "jest/prefer-to-be-undefined": 2, "jest/prefer-to-contain": 2, "jest/prefer-to-have-length": 2, "jest/prefer-todo": 2, + "jest/require-hook": 0, "jest/require-to-throw-message": 0, "jest/require-top-level-describe": 0, "jest/unbound-method": 0, - "jest/valid-describe": 2, + "jest/valid-describe-callback": 2, "jest/valid-expect": 2, "jest/valid-expect-in-promise": 2, "jest/valid-title": 2, @@ -1196,7 +1192,7 @@ Snapshot Diff: "jest/prefer-strict-equal": 0, - "jest/prefer-to-be": 1, + "jest/prefer-to-be": 2, - "jest/prefer-to-be-null": 2, + "jest/prefer-to-contain": 2, @@ --- --- @@ "no-caller": 2, - "no-case-declarations": 1, diff --git a/src/eslint-config-adeira/__tests__/__snapshots__/presets.test.js.snap b/src/eslint-config-adeira/__tests__/__snapshots__/presets.test.js.snap index 831ae5265d..f24a39d866 100644 --- a/src/eslint-config-adeira/__tests__/__snapshots__/presets.test.js.snap +++ b/src/eslint-config-adeira/__tests__/__snapshots__/presets.test.js.snap @@ -665,7 +665,6 @@ Object { ], "jest/consistent-test-it": 0, "jest/expect-expect": 0, - "jest/lowercase-name": 0, "jest/max-nested-describe": Array [ 1, Object { @@ -679,7 +678,6 @@ Object { "jest/no-disabled-tests": 2, "jest/no-done-callback": 0, "jest/no-duplicate-hooks": 2, - "jest/no-expect-resolves": 0, "jest/no-export": 2, "jest/no-focused-tests": 2, "jest/no-hooks": 0, @@ -695,24 +693,22 @@ Object { "jest/no-test-callback": 0, "jest/no-test-prefixes": 0, "jest/no-test-return-statement": 2, - "jest/no-truthy-falsy": 0, "jest/prefer-called-with": 2, "jest/prefer-expect-assertions": 0, "jest/prefer-expect-resolves": 1, "jest/prefer-hooks-on-top": 2, - "jest/prefer-inline-snapshots": 0, + "jest/prefer-lowercase-title": 0, "jest/prefer-spy-on": 0, "jest/prefer-strict-equal": 0, "jest/prefer-to-be": 1, - "jest/prefer-to-be-null": 2, - "jest/prefer-to-be-undefined": 2, "jest/prefer-to-contain": 2, "jest/prefer-to-have-length": 2, "jest/prefer-todo": 2, + "jest/require-hook": 0, "jest/require-to-throw-message": 0, "jest/require-top-level-describe": 0, "jest/unbound-method": 0, - "jest/valid-describe": 2, + "jest/valid-describe-callback": 2, "jest/valid-expect": 2, "jest/valid-expect-in-promise": 2, "jest/valid-title": 2, diff --git a/src/eslint-config-adeira/src/presets/jest.js b/src/eslint-config-adeira/src/presets/jest.js index d152f7932a..05d821ecd7 100644 --- a/src/eslint-config-adeira/src/presets/jest.js +++ b/src/eslint-config-adeira/src/presets/jest.js @@ -14,7 +14,7 @@ module.exports = ({ // Jest (https://github.com/jest-community/eslint-plugin-jest) 'jest/consistent-test-it': OFF, 'jest/expect-expect': OFF, - 'jest/lowercase-name': OFF, + 'jest/prefer-lowercase-title': OFF, 'jest/max-nested-describe': [NEXT_VERSION_ERROR, { max: 5 }], 'jest/no-alias-methods': OFF, 'jest/no-commented-out-tests': OFF, @@ -23,7 +23,6 @@ module.exports = ({ 'jest/no-disabled-tests': ERROR, 'jest/no-done-callback': OFF, 'jest/no-duplicate-hooks': ERROR, - 'jest/no-expect-resolves': OFF, 'jest/no-export': ERROR, 'jest/no-focused-tests': ERROR, 'jest/no-hooks': OFF, // TODO: WARN (?) @@ -39,26 +38,23 @@ module.exports = ({ 'jest/no-test-callback': OFF, 'jest/no-test-prefixes': OFF, 'jest/no-test-return-statement': ERROR, - 'jest/no-truthy-falsy': OFF, 'jest/prefer-called-with': ERROR, 'jest/prefer-expect-assertions': OFF, 'jest/prefer-hooks-on-top': ERROR, - 'jest/prefer-inline-snapshots': OFF, 'jest/prefer-spy-on': OFF, 'jest/prefer-strict-equal': OFF, // TODO: WARN - 'jest/prefer-to-be-null': ERROR, - 'jest/prefer-to-be-undefined': ERROR, 'jest/prefer-to-contain': ERROR, 'jest/prefer-to-have-length': ERROR, 'jest/prefer-todo': ERROR, 'jest/require-to-throw-message': OFF, 'jest/require-top-level-describe': OFF, 'jest/unbound-method': OFF, - 'jest/valid-describe': ERROR, + 'jest/valid-describe-callback': ERROR, 'jest/valid-expect': ERROR, 'jest/valid-expect-in-promise': ERROR, 'jest/valid-title': ERROR, 'jest/prefer-expect-resolves': NEXT_VERSION_ERROR, 'jest/prefer-to-be': NEXT_VERSION_ERROR, + 'jest/require-hook': OFF, }, } /*: EslintConfig */);