You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the Coachmark component the step count, for example "1 of 3" has hardcoded the "of" string. The expected behavior is that this string is localized, or is at least configurable so the client can pass in the string to use in this case.
Actual behavior
The "of" word is hardcoded.
Screenshots
What browsers are you seeing the problem in?
Chrome
How can we reproduce this issue?
Bug was discovered in a pre-release version so I can't share my own reproduction steps, as the feature has not been publicly released. But this surely reproduces anywhere Coachmark component is used.
Change language to non-english
Enter multi-step coachmark tour
Code where this is hard-coded is here
Code of conduct
Impacted component(s)
Coachmark
Expected behavior
In the Coachmark component the step count, for example "1 of 3" has hardcoded the "of" string. The expected behavior is that this string is localized, or is at least configurable so the client can pass in the string to use in this case.
Actual behavior
The "of" word is hardcoded.
Screenshots
What browsers are you seeing the problem in?
Chrome
How can we reproduce this issue?
Bug was discovered in a pre-release version so I can't share my own reproduction steps, as the feature has not been publicly released. But this surely reproduces anywhere Coachmark component is used.
Code where this is hard-coded is here
spectrum-web-components/packages/coachmark/src/Coachmark.ts
Line 278 in a2b6bea
Sample code or abstract reproduction which illustrates the problem
No response
Severity
SEV 3
Logs taken while reproducing problem
No response
The text was updated successfully, but these errors were encountered: