Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when test does not pass #6

Open
mbuczko opened this issue Apr 27, 2015 · 3 comments
Open

Exception when test does not pass #6

mbuczko opened this issue Apr 27, 2015 · 3 comments

Comments

@mbuczko
Copy link

mbuczko commented Apr 27, 2015

I'm not sure how much this is an issue but when test does not pass, strange stacktrace is shown. I've changed boot-test test to fail:

Testing adzerk.boot-test.test

FAIL in (have-you-tried) (test.clj:5)
expected: 2
  actual: 1
    diff: - 2
          + 1

Ran 1 tests containing 1 assertions.
1 failures, 0 errors.
             clojure.lang.ExceptionInfo: clojure.lang.ExceptionInfo: Some tests failed or errored {:type :summary, :fail 1, :error 0, :pass 0, :test 1}
    data: {:file
           "/var/folders/fz/r0qnzmvd69lf__k3m920myym0000gn/T/boot.user5071628562246700946.clj", :line 29}
java.util.concurrent.ExecutionException: clojure.lang.ExceptionInfo: Some tests failed or errored {:type :summary, :fail 1, :error 0, :pass 0, :test 1}
    clojure.lang.ExceptionInfo: Some tests failed or errored
        data: {:type :summary, :fail 1, :error 0, :pass 0, :test 1}
             clojure.core/ex-info                  core.clj:      4591
  adzerk.boot-test/eval453/fn/fn/fn                boot_test.clj:   66
                 boot.core/run-tasks               core.clj:       680
                            ...
              boot.user/eval513/fn  boot.user5071628562246700946.clj:   29
clojure.core/binding-conveyor-fn/fn                         core.clj: 1914

To be honest I have totally no clue what does this stacktrace mean. Is it really so informative to keep it printed each time the test fails?

@niwinz
Copy link

niwinz commented May 24, 2015

Completely agree!
This stacktrace is completely useless.

@alandipert
Copy link
Member

The idea with throwing an exception was that upstream tasks like speak could catch and report it. Perhaps this behavior should be off by default?

@mbuczko
Copy link
Author

mbuczko commented May 25, 2015

That would be great. As for now there is no way to switch it off without using "upstream" tasks or wrapping it into magic try-catch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants