Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm INTERNAL_API_URL fix #283

Closed
wants to merge 2 commits into from

Conversation

a-monteiro
Copy link

What

It fixes the Airbyte API Server helm chart.

How

We added an extra env variable for the Airbyte internal API URL prefixed with http://.

Recommended reading order

Can this PR be safely reverted / rolled back?

If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.

Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.

If unsure, leave it blank.

  • YES 💚
  • NO ❌

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

@saisona
Copy link

saisona commented Nov 16, 2023

Could that be possible to merge that PR ASAP please !

@Anton-Shutik
Copy link

Any updates on this one ?

@Santhin
Copy link

Santhin commented Dec 7, 2023

For workaround, you need to add to the values

  airbyte-api-server:
    extraEnv:
      - name: INTERNAL_API_HOST
        valueFrom:
          configMapKeyRef:
            name: airbyte-additional-envs
            key: INTERNAL_API_URL

And create cm

apiVersion: v1
data:
  INTERNAL_API_URL: http://airbyte-airbyte-server-svc:8001
kind: ConfigMap
metadata:
  name: airbyte-additional-envs

And restart deployment to inject new env_vars and cm

@stevenmurphy12
Copy link

For workaround, you need to add to the values

  airbyte-api-server:
    extraEnv:
      - name: INTERNAL_API_HOST
        valueFrom:
          configMapKeyRef:
            name: airbyte-additional-envs
            key: INTERNAL_API_URL

And create cm

apiVersion: v1
data:
  INTERNAL_API_URL: http://airbyte-airbyte-server-svc:8001
kind: ConfigMap
metadata:
  name: airbyte-additional-envs

And restart deployment to inject new env_vars and cm

This worked for me, thank you.

@ldmoose
Copy link

ldmoose commented Dec 20, 2023

This appears to be fixed as of helm version 0.50.10 with this commit: b28dc9c

@a-monteiro
Copy link
Author

This appears to be fixed as of helm version 0.50.10 with this commit: b28dc9c

Indeed! Closing this.

@a-monteiro a-monteiro closed this Dec 20, 2023
@a-monteiro a-monteiro deleted the helm-internal-api-fix branch December 20, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants