Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): use http scheme for INTERNAL_API_HOST #293

Closed

Conversation

justenwalker
Copy link
Contributor

What

The current chart doesn't use a scheme for INTERNAL_API_HOST causing the api-server fail to reach the internal config API.

How

This fix adds an explicit http:// prefix to the value of INTERNAL_API_HOST in the configmap.

Recommended reading order

  1. charts/airbyte/templates/env-configmap.yaml

Can this PR be safely reverted / rolled back?

If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.

Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.

If unsure, leave it blank.

  • YES 💚
  • NO ❌

🚨 User Impact 🚨

None

Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@justenwalker
Copy link
Contributor Author

Ok, so this doesn't actually work as-is. The reason is the worker expects this value in the form host:port so when the http:// prefix is added, that client setup breaks:

2023-12-07 20:26:16 ERROR i.m.r.Micronaut(handleStartupException):338 - Error starting Micronaut server: Error instantiating bean of type  [io.airbyte.api.client.AirbyteApiClient]

Message: For input string: "//airbyte-airbyte-server-svc"
Path Taken: new ApplicationInitializer() --> ApplicationInitializer.checkConnectionActivities --> List.checkConnectionActivities([CheckConnectionActivity checkConnectionActivity]) --> new CheckConnectionActivityImpl(WorkerConfigsProvider workerConfigsProvider,ProcessFactory processFactory,SecretsR
io.micronaut.context.exceptions.BeanInstantiationException: Error instantiating bean of type  [io.airbyte.api.client.AirbyteApiClient]

Message: For input string: "//airbyte-airbyte-server-svc"
Path Taken: new ApplicationInitializer() --> ApplicationInitializer.checkConnectionActivities --> List.checkConnectionActivities([CheckConnectionActivity checkConnectionActivity]) --> new CheckConnectionActivityImpl(WorkerConfigsProvider workerConfigsProvider,ProcessFactory processFactory,SecretsR
    at io.micronaut.context.DefaultBeanContext.resolveByBeanFactory(DefaultBeanContext.java:2367) ~[micronaut-inject-3.10.1.jar:3.10.1]
                                                                             

@justenwalker justenwalker deleted the jwalker/chart-internal-api branch December 7, 2023 20:28
@terencecho
Copy link
Contributor

this issue should be fixed by this commit: b28dc9c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants