fix(socat): handle ipv6 and ipv4 communication from socat to runner #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…runner When trying to use Airbyte in an IPV6 enabled kubernetes cluster the socat process fails with E TCP: wrong number of parameters (9 instead of 2). This PR fixes that using the TCP6:[IP]:port syntax when identifying an IPV6 address for the original process runner host.
|
+1 on this, I wrote a patch for internal testing twice now on two separate pull requests. This needs more attention and a fix so we do not have to manually patch it internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When trying to use Airbyte in an IPV6 enabled kubernetes cluster the socat process fails with
This PR fixes that using the TCP6:[IP]:port syntax when identifying an IPV6 address for the original process runner host.
How
By checking the process runner host to check if it is an Ipv6 or Ipv4 format
Can this PR be safely reverted and rolled back?