Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

destination bigquery 1s1t: print subquery stats #28373

Merged
merged 5 commits into from
Jul 18, 2023
Merged

destination bigquery 1s1t: print subquery stats #28373

merged 5 commits into from
Jul 18, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jul 17, 2023 •
edited
Loading

turns out it is possible to to find the cost of each query within a transaction, it's just a little involved.

the bq.listJobs is a real api call, so it takes around 1 second ish. Arguably that shouldn't happen on the main thread, but... (1) meh, it's 1 additional second every few minutes, and (2) async should make this less bad since other threads are still doing things.

logs look something like this
image

also use this in the sqlgenerator integration test for convenience.

@edgao edgao requested a review from a team as a code owner July 17, 2023 21:34
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited by edgao
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

cynthiaxyin
cynthiaxyin approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@cynthiaxyin cynthiaxyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!

...io/airbyte/integrations/destination/bigquery/typing_deduping/BigQueryDestinationHandler.java Show resolved Hide resolved
@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery test report (commit 81cb72af47) - ❌

⏲️ Total pipeline duration: 41mn09s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ❌
QA checks ✅
Build connector tar ✅
Build destination-bigquery docker image for platform linux/x86_64 ✅
Build airbyte/normalization:dev ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery-denormalized test report (commit 81cb72af47) - ✅

⏲️ Total pipeline duration: 22mn55s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Build connector tar ✅
Build destination-bigquery-denormalized docker image for platform linux/x86_64 ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery-denormalized:integrationTest ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery-denormalized test report (commit 126c6de791) - ✅

⏲️ Total pipeline duration: 24mn24s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Build connector tar ✅
Build destination-bigquery-denormalized docker image for platform linux/x86_64 ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery-denormalized:integrationTest ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery test report (commit 126c6de791) - ✅

⏲️ Total pipeline duration: 37mn51s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Build connector tar ✅
Build destination-bigquery docker image for platform linux/x86_64 ✅
Build airbyte/normalization:dev ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@edgao
Copy link
Contributor Author

edgao commented Jul 18, 2023

/approve-and-merge reason="current failure is a transient dockerhub thing; tests were prevoiusly passing"

@octavia-approvington
Copy link
Contributor

This looks fine!
Merged!
Imagine it being fine

@octavia-approvington octavia-approvington merged commit d6c7ff0 into master Jul 18, 2023
11 of 12 checks passed
@octavia-approvington octavia-approvington deleted the edga/1s1t/even_more_stats branch July 18, 2023 15:09
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@edgao @efimmatytsin
destination bigquery 1s1t: print subquery stats (airbytehq#28373)
26e8941 
* print subquery stats

* indicate truncation

* use destinationhandler in test for convenience
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cynthiaxyin cynthiaxyin cynthiaxyin approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/destination/bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgao @octavia-squidington-iii @octavia-approvington @cynthiaxyin