Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-stripe: Revert 3.17.2 and apply atm_fee changes #29309

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Aug 9, 2023

Overview

Related to an OC issue where a source-stripe user cannot refresh their schema.

See slack channel for more details

@bnchrch bnchrch requested a review from davydov-d August 9, 2023 20:27
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe labels Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@bnchrch bnchrch requested a review from lazebnyi August 9, 2023 20:27
@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit a98a1b009b) - ❌

⏲️ Total pipeline duration: 10mn07s

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 41dbedde07) - ❌

⏲️ Total pipeline duration: 09mn15s

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@bnchrch
Copy link
Contributor Author

bnchrch commented Aug 10, 2023

Possibly resolves https://github.com/airbytehq/oncall/issues/2703

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest leaving the changes related to the accessibility strategy and documents.

@bnchrch if you want I can do this

}


class StripeAvailabilityStrategy(HttpAvailabilityStrategy):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need leave availability strategy and test with it.

@@ -1,50 +1,33 @@
# Stripe

This page contains the setup guide and reference information for the Stripe source connector.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to leave changes to documents without rolling back.

@bnchrch
Copy link
Contributor Author

bnchrch commented Aug 10, 2023

This fix works! But we need to update some catalogs manually before we can rollout
https://github.com/airbytehq/oncall/issues/2703#issuecomment-1673959410

@lazebnyi Happy to leave the docs in but I would rather keep this version as small as a deviation from 3.17.1 as possible as 3.17.2 proved to have some issues and I dont want to accidentally introduce a bug as we fix.

That means I would like to leave out the availabilty strategy changes.

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 06b8393304) - ❌

⏲️ Total pipeline duration: 10mn00s

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@bnchrch bnchrch requested review from a team as code owners August 11, 2023 20:11
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Aug 11, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-orbit test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 02mn38s

Step Result
Validate airbyte-integrations/connectors/source-orbit/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-orbit docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-orbit test

@octavia-squidington-iii
Copy link
Collaborator

source-breezometer test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 02mn41s

Step Result
Validate airbyte-integrations/connectors/source-breezometer/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-breezometer docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-breezometer test

@octavia-squidington-iii
Copy link
Collaborator

source-bamboo-hr test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 02mn38s

Step Result
Validate airbyte-integrations/connectors/source-bamboo-hr/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-bamboo-hr docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bamboo-hr test

@octavia-squidington-iii
Copy link
Collaborator

source-clockify test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 03mn07s

Step Result
Validate airbyte-integrations/connectors/source-clockify/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-clockify docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-clockify test

@octavia-squidington-iii
Copy link
Collaborator

source-zapier-supported-storage test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 02mn47s

Step Result
Validate airbyte-integrations/connectors/source-zapier-supported-storage/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-zapier-supported-storage docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zapier-supported-storage test

@octavia-squidington-iii
Copy link
Collaborator

source-activecampaign test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 02mn56s

Step Result
Validate airbyte-integrations/connectors/source-activecampaign/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-activecampaign docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-activecampaign test

@octavia-squidington-iii
Copy link
Collaborator

source-courier test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 02mn53s

Step Result
Validate airbyte-integrations/connectors/source-courier/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-courier docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-courier test

@octavia-squidington-iii
Copy link
Collaborator

source-pocket test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 03mn04s

Step Result
Validate airbyte-integrations/connectors/source-pocket/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-pocket docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-pocket test

@octavia-squidington-iii
Copy link
Collaborator

source-freshcaller test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 06mn51s

Step Result
Validate airbyte-integrations/connectors/source-freshcaller/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-freshcaller docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-freshcaller test

@octavia-squidington-iii
Copy link
Collaborator

source-younium test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 03mn14s

Step Result
Validate airbyte-integrations/connectors/source-younium/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-younium docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-younium test

@octavia-squidington-iii
Copy link
Collaborator

source-secoda test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 02mn32s

Step Result
Validate airbyte-integrations/connectors/source-secoda/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-secoda docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-secoda test

@octavia-squidington-iii
Copy link
Collaborator

source-sftp-bulk test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 03mn34s

Step Result
Validate airbyte-integrations/connectors/source-sftp-bulk/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-sftp-bulk docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-sftp-bulk test

@octavia-squidington-iii
Copy link
Collaborator

source-linnworks test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 37.46s

Step Result
Validate airbyte-integrations/connectors/source-linnworks/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-linnworks docker image for platform linux/x86_64

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linnworks test

@octavia-squidington-iii
Copy link
Collaborator

source-babelforce test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 02mn43s

Step Result
Validate airbyte-integrations/connectors/source-babelforce/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-babelforce docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-babelforce test

@octavia-squidington-iii
Copy link
Collaborator

source-pinterest test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 05mn24s

Step Result
Validate airbyte-integrations/connectors/source-pinterest/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-pinterest docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-pinterest test

@octavia-squidington-iii
Copy link
Collaborator

source-omnisend test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 02mn56s

Step Result
Validate airbyte-integrations/connectors/source-omnisend/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-omnisend docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-omnisend test

@octavia-squidington-iii
Copy link
Collaborator

source-chargify test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 03mn39s

Step Result
Validate airbyte-integrations/connectors/source-chargify/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-chargify docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-chargify test

@octavia-squidington-iii
Copy link
Collaborator

source-persistiq test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 03mn04s

Step Result
Validate airbyte-integrations/connectors/source-persistiq/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-persistiq test

@octavia-squidington-iii
Copy link
Collaborator

source-polygon-stock-api test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 03mn20s

Step Result
Validate airbyte-integrations/connectors/source-polygon-stock-api/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-polygon-stock-api docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-polygon-stock-api test

@octavia-squidington-iii
Copy link
Collaborator

source-qualaroo test report (commit 679da8f432) - ❌

⏲️ Total pipeline duration: 03mn40s

Step Result
Validate airbyte-integrations/connectors/source-qualaroo/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-qualaroo docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-qualaroo test

@bnchrch bnchrch force-pushed the bnchrch/p0-stripe-object-nodes-23-08-02/revert-and-fix-atm-schema branch from 679da8f to 8359c51 Compare August 11, 2023 20:40
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Aug 11, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 8359c51f9e) - ❌

⏲️ Total pipeline duration: 07mn42s

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@bnchrch
Copy link
Contributor Author

bnchrch commented Aug 11, 2023

/approve-and-merge reason="cat test failing on master for additional fields"

@octavia-approvington
Copy link
Contributor

Check that box
TODO complete

@octavia-approvington octavia-approvington merged commit 1219e66 into master Aug 11, 2023
17 checks passed
@octavia-approvington octavia-approvington deleted the bnchrch/p0-stripe-object-nodes-23-08-02/revert-and-fix-atm-schema branch August 11, 2023 22:09
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
* Revert ":bug: Source Stripe: add availability strategy (airbytehq#28911)"

This reverts commit cd51881.

* Run git checkout cd51881 -- airbyte-integrations/connectors/source-stripe/source_stripe/schemas/transactions.json

* Bump version to 3.17.3

* Update change log

* update test config

* Remove skip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/stripe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants