Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for defining sgd/batch in exp_normal_n5p2.R #6

Open
dustinvtran opened this issue Dec 9, 2014 · 4 comments
Open

Remove need for defining sgd/batch in exp_normal_n5p2.R #6

dustinvtran opened this issue Dec 9, 2014 · 4 comments
Assignees

Comments

@dustinvtran
Copy link
Member

sgd.R should be generic enough to work for all experiments.

@dustinvtran dustinvtran self-assigned this Dec 9, 2014
@dustinvtran dustinvtran changed the title Remove need for defining sgd in example R scripts Remove need for defining sgd in example R scripts Dec 9, 2014
@dustinvtran dustinvtran changed the title Remove need for defining sgd in example R scripts Remove need for defining sgd/batch in exp_normal_n5p2.R Dec 9, 2014
@ptoulis
Copy link
Contributor

ptoulis commented Dec 9, 2014

Yes i think we need to have one code sgd.R for the SGD implementations
and one examples_main.R having generic code for the experiments --
the exp_* scripts should be a few lines long and should be there to let others run the experiments
quickly.

@dustinvtran
Copy link
Member Author

run.all() in exp_poisson_n4p1.R is close to achieving that goal and will eventually be extended and placed into another file. There should also be more diagnostic functions aside from plot.risk(), such as a wrapper for performing time benchmarks.

@ptoulis
Copy link
Contributor

ptoulis commented Dec 9, 2014

Agreed. Let' s keep working on the other code, and eventually we will shape up the exp scripts
when the rest is finalized.

@dustinvtran
Copy link
Member Author

e0b9cd2 cleans this as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants