Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register all marathon apps in consul #82

Open
tsaridas opened this issue May 10, 2016 · 2 comments
Open

Register all marathon apps in consul #82

tsaridas opened this issue May 10, 2016 · 2 comments

Comments

@tsaridas
Copy link

I would actually like to have all services in marathon added to consul but I see the MARATHON_CONSUL_LABEL value is constant and there is no configuration for it.

@janisz
Copy link
Contributor

janisz commented May 10, 2016

Hi @tsaridas

It's good idea to make MARATHON_CONSUL_LABEL configurable and add possibility to register all services (e.g. provided config value is empty). Changes are required in AppId.ConsulServiceName and Config.

This issue is related to #81 and could be resolved in same way — MARATHON_CONSUL_LABEL could be provided as a parameter or as a global variable that will be setup at the beginning of main.

@janisz
Copy link
Contributor

janisz commented Jun 17, 2016

@tsaridas I think your problem is not related to MARATHON_CONSUL_LABEL. In my opinion it should stay as is. We could add another configuration option to say all services should be registered in Consul. If we add special meaning for empty string in MARTHON_CONSUL_LABEL we will lose ability to change names for single service.

@janisz janisz added this to the 1.0 milestone Aug 16, 2016
@janisz janisz changed the title move MARATHON_CONSUL_LABEL to configuration file Register all marathon apps in consul Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants