Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs (branched from master) can end with tab in the filename and make visiting the file impossible #133

Open
DivineDominion opened this issue Aug 20, 2022 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed WAITING Waiting for response from someone

Comments

@DivineDominion
Copy link

DivineDominion commented Aug 20, 2022

When jumping to any of the files from this section that end with a perceivable wide space between file name and the TOPDO marker, magit-todos fails to find the file. It notably does work for the topmost item depicted, though:

Screen Shot 2022-08-20 at 13 53 06

I was playing with the result of (magit-todos-item-filename item) and found that this result contained a trailing \t tab character. That wasn't apparent in message output until I surrounded the string with delimiters.

Looking at #122 I'm not sure if these tabs are supposed to be there, though. Is this a configuration error on my end?

@alphapapa
Copy link
Owner

I don't know how a tab could end up in the filename unless the filename itself contained one. Of course, that's very unlikely, but not impossible. Can you verify that that's not the case? If it's not, maybe there's a bug in this package somewhere, but you should try to reproduce it in a clean Emacs configuration, e.g. using https://github.com/alphapapa/with-emacs.sh

@alphapapa alphapapa added the bug Something isn't working label Sep 9, 2022
@alphapapa alphapapa added help wanted Extra attention is needed WAITING Waiting for response from someone labels Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed WAITING Waiting for response from someone
Projects
None yet
Development

No branches or pull requests

2 participants