prop-types should be removed from production builds published to npm

[dballance]

prop-types appearing in production builds makes downstream consumption with rollup or another bundler more complex than it should be.

As it stand today, I have to ship prop-types with my bundle or utilize babel + plugin to shake out prop-types.

[JorgenEvens]

Hi @dballance,

Would wrapping them in a NODE_ENV == 'production' check fix your issues with rollup? I'd prefer to have propTypes available during development.

More info on this suggestions: [1] and [2]

[dballance]

I think so!

Basically, I'm down for whatever way you want to handle it. Having them in dev is great and I think you should absolutely have that option if you want. I don't think there is an expectation that they disappear entirely.

As long as prop-types isn't a peer dep or directly referenced in a production bundle (via NODE_ENV or Babel plugin or similar) it would be much better from a consumption standpoint.

Thanks!!

[ruckc]

bump.... running into this today through react-avatar