Identify pool on init #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewMacmurray
force-pushed
the
identify-pool
branch
from
f364531
to
d57c80a
Compare
andrewMacmurray
force-pushed
the
identify-pool
branch
from
d57c80a
to
e49d408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19
When a task
Poolis initialised it now asks the runner for a unique id before any tasks are executed (the runner keeps track of the number of pools that have been initialised).This prevents some weird behaviour seen in a typical single page app setup where switching back and forth between pages with long running tasks (e.g. Page1 and Page2 would mean a page might receive task results from a previous page init.