Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "apply_config_change()" code across local, iroh and tcp helps #505

Open
andrewdavidmackenzie opened this issue Oct 5, 2024 · 1 comment
Labels
code Relates to code cleanliness, elegance, maintainability or tests
Milestone

Comments

@andrewdavidmackenzie
Copy link
Owner

The code is almost identical, except the sending mechanism at the very end.
Merge them all, either by

  • providing a closure to do the sending at the end
  • using a trait object that does the sending and pass it in
  • using generics to write one code (but then 3 will be generated)

That could unlock a further merge of the three methods in hardware_subscription.rs too....

@andrewdavidmackenzie andrewdavidmackenzie added the code Relates to code cleanliness, elegance, maintainability or tests label Oct 5, 2024
@andrewdavidmackenzie andrewdavidmackenzie added this to the 0.5.0 Release milestone Oct 5, 2024
@andrewdavidmackenzie
Copy link
Owner Author

Add a struct for connection, and make it generic over some type, maybe HardwareTarget?, and then use that in subscription?

@andrewdavidmackenzie andrewdavidmackenzie added this to the 0.6.0 milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Relates to code cleanliness, elegance, maintainability or tests
Projects
None yet
Development

No branches or pull requests

1 participant