Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if dataverse on CRAN has been updated beyond 0.2.0 #72

Open
andybega opened this issue Oct 19, 2020 · 1 comment
Open

Check if dataverse on CRAN has been updated beyond 0.2.0 #72

andybega opened this issue Oct 19, 2020 · 1 comment

Comments

@andybega
Copy link
Owner

The icews package will not properly work with the CRAN version of dataverse (0.2.0 from 2017 as I'm writing this). This was brought up here in issues #51 and #58, and is discussed in dataverse at their issue #33 (which I don't want to auto link).

Originally I added a fix by using some dataverse internal functions to re-construct a correct API URL. R check does not like that.

So, instead, I added a warning that is displayed on package attach if the detected dataverse version is below 0.2.1.9001 (here 82e632e). The new version is not on CRAN and has to be manually installed from GitHub.

This doesn't impact the tests, and I just verified that the package will pass R check with the CRAN version of dataverse, even though it will not work. But otherwise I get a R check note about Remotes in the DESCRIPTION file, so I'm gonna take it out prior to release to CRAN.

@andybega andybega changed the title Check if dataverse on CRAN has been updated Check if dataverse on CRAN has been updated beyond 0.2.0 Oct 19, 2020
andybega added a commit that referenced this issue Oct 20, 2020
instead of a warning in .onLoad, issue a startup message if the package version is too low, and don't throw an error unless download_file() is actually reached
@andybega andybega mentioned this issue Oct 20, 2020
16 tasks
@andybega
Copy link
Owner Author

I previously had code that would issue a warning in .onLoad. This doesn't work with R check, so I changed it to:

  • issue a startup message when the package is attached (.onAttach)
  • issue an error in download_file() if that point is reached and the dataverse version is old

All the changes are marked with "see #72", so a file search should show all the relevant bits that need to be removed if this issue ever becomes mute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant