You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The icews package will not properly work with the CRAN version of dataverse (0.2.0 from 2017 as I'm writing this). This was brought up here in issues #51 and #58, and is discussed in dataverse at their issue #33 (which I don't want to auto link).
Originally I added a fix by using some dataverse internal functions to re-construct a correct API URL. R check does not like that.
So, instead, I added a warning that is displayed on package attach if the detected dataverse version is below 0.2.1.9001 (here 82e632e). The new version is not on CRAN and has to be manually installed from GitHub.
This doesn't impact the tests, and I just verified that the package will pass R check with the CRAN version of dataverse, even though it will not work. But otherwise I get a R check note about Remotes in the DESCRIPTION file, so I'm gonna take it out prior to release to CRAN.
The text was updated successfully, but these errors were encountered:
andybega
changed the title
Check if dataverse on CRAN has been updated
Check if dataverse on CRAN has been updated beyond 0.2.0
Oct 19, 2020
instead of a warning in .onLoad, issue a startup message if the package version is too low, and don't throw an error unless download_file() is actually reached
The icews package will not properly work with the CRAN version of dataverse (0.2.0 from 2017 as I'm writing this). This was brought up here in issues #51 and #58, and is discussed in dataverse at their issue #33 (which I don't want to auto link).
Originally I added a fix by using some dataverse internal functions to re-construct a correct API URL. R check does not like that.
So, instead, I added a warning that is displayed on package attach if the detected dataverse version is below 0.2.1.9001 (here 82e632e). The new version is not on CRAN and has to be manually installed from GitHub.
This doesn't impact the tests, and I just verified that the package will pass R check with the CRAN version of dataverse, even though it will not work. But otherwise I get a R check note about Remotes in the DESCRIPTION file, so I'm gonna take it out prior to release to CRAN.
The text was updated successfully, but these errors were encountered: