Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime goexit when Jira url is wrong (no such host) #211

Closed
jiaohe opened this issue May 3, 2019 · 6 comments
Closed

runtime goexit when Jira url is wrong (no such host) #211

jiaohe opened this issue May 3, 2019 · 6 comments
Labels
breaking-change help wanted needs triage Ticket that needs triage (a proper look for classification) v2
Milestone

Comments

@jiaohe
Copy link

jiaohe commented May 3, 2019

panic occurred if Jira url is wrong (no such host)

projectmgmt-release.projectmgmt.0 runtime.goexit

projectmgmt-release.projectmgmt.0 projectmgmt-service/handler.(*PMHandler).GetUserIssue
projectmgmt-release.projectmgmt.0 projectmgmt-service/providers/jira/jira.go:172
projectmgmt-release.projectmgmt.0 projectmgmt-service/providers/jira.(*Jira).GetUserIssues
projectmgmt-release.projectmgmt.0 projectmgmt-service/providers/jira/jira.go:272
projectmgmt-release.projectmgmt.0 projectmgmt-service/providers/jira.(*Jira).SearchIssue
projectmgmt-release.projectmgmt.0 /tmp/build/38b8ed6e/gopath/src/github.com/andygrunwald/go-jira/issue.go:845
projectmgmt-release.projectmgmt.0 github.com/andygrunwald/go-jira.(*IssueService).Search
projectmgmt-release.projectmgmt.0 /tmp/build/38b8ed6e/gopath/src/github.com/andygrunwald/go-jira/error.go:24
projectmgmt-release.projectmgmt.0 github.com/andygrunwald/go-jira.NewJiraError

@ghostsquad
Copy link
Contributor

How would you like to see this changed?

@ghostsquad
Copy link
Contributor

I definitely don't think that a panic is appropriate. @jiaohe Can you provide a code sample that reproduces this issue?

@andygrunwald
Copy link
Owner

No activity for>60 days.
@jiaohe Please let us know if you have more information on this. We will re-open this issue.

@fffinkel
Copy link
Contributor

Re-opening stale comment! I'll be helping out with the project a bit and Stale Bot is no more, so we're re-opening tickets that were closed due to age.

I will eventually try to reproduce this issue, so I would like to keep it in our queue.

@fffinkel fffinkel reopened this Aug 31, 2020
@fffinkel fffinkel removed the stale label Aug 31, 2020
@andygrunwald andygrunwald added needs triage Ticket that needs triage (a proper look for classification) and removed enhancement labels Aug 20, 2022
@andygrunwald andygrunwald added this to the Road to v2 milestone Aug 21, 2022
@andygrunwald
Copy link
Owner

Hey,

I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your issue + you like to sponsor it, please contact me.

What does this mean for my issue?

We will work on this issue indirectly.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using this library.
If there is anything else you would like to tell us, let us know!

@andygrunwald
Copy link
Owner

This ticket is missing information.
Only the examples contain a panic(). This is considered fine, due to the showcase functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change help wanted needs triage Ticket that needs triage (a proper look for classification) v2
Projects
None yet
Development

No branches or pull requests

4 participants