Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting on Chapter and Novel end location #3

Open
gregziegan opened this issue Sep 12, 2015 · 2 comments
Open

Voting on Chapter and Novel end location #3

gregziegan opened this issue Sep 12, 2015 · 2 comments

Comments

@gregziegan
Copy link
Member

Need to determine a course of action for contributors to decide when a chapter and novel should end.

Proposed solutions

Chapter

Have an End Chapter action that can be toggled once by each Contributor per Chapter, and when the majority of active Contributors have voted to end the Chapter, a sentence countdown will begin. A good default would be 10 sentences. Enough to wrap up the Chapter within one to two paragraphs.

Novel

Similar to the End Chapter action, but require a larger majority of active Contributors to start the countdown. A default countdown could begin at 50 sentences.

@Jmmaroli
Copy link

Two buttons can be simplified to 1 button by having and end button with a popup that specifies chapter or novel. Alternatively, a key phrase or token can be voted to end the chapter or novel and added to the token database. Ex) "End Chapter" and "End Novel"

I prefer the token method, we just need to specify that in the instructions or rules. Buttons add clutter, but if we have an upper and lower menu on the mobile apps then it could work.

@gregziegan
Copy link
Member Author

I just edited the above comment to change button -> action. This is not a repo with a front-end, simply the API. So, specific views won't be discussed here unless used to help visualize why a restructure would be necessary.

The actions above need to be facilitated by something on the backend. We cannot do a PUT/PATCH on Novel & Chapter since that means a single user can alter the is_completed field of the resource.

Vote is currently used only for submitting the next token. It is also linked explicitly to a Chapter, not a Novel. So attempting to make Vote behave as both a Vote for a Novel Endpoint, Chapter Endpoint, and eventually any other functionality will mean a lot more nullable fields and make it a confusing resource by having a large number of differing responsibilities.

Perhaps a CompletionVote can be used for both novels and chapters. Either as an abstract model and two derivatives: NovelCompletionVote and ChapterCompletionVote can be made, or there could be a polymorphic way to address both.

When a new CompletionVote is added, the system can query and detect when the thresholds I proposed above are reached. Then, a system update of some sort can occur and in a certain number of sentences the Novel/Chapter will end.

Whatever that update is after the threshold, it should be query-able so that something like this is possible:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants