-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with ejs template #297
Comments
Hi,
Sorry if this approach seems a bit over simplified. |
Yeah that approach sounds pretty good. I have a branch up where I am working on getting the render items pulled into the config that you pass into the server. I am 90% of the way there (#301) just have some failing tests to get squared away. But looking through that may give you some more insight. I am hoping to find sometime this weekend to get that change finished up and merged into the next release branch. You can probably start working with that branch as your base. |
That branch being this one: https://github.com/ansble/monument/tree/feature/swappable-template-engines-add-config-objects |
also the config object would include the template engine itself, so the ejs engine as well as any config that it needs. |
If you start from the Strade Bianchi branch you should be able to make a
run at it now. Got the config object pull request merged over the weekend
…On Fri, Nov 25, 2016 at 2:34 AM, Abhinav Sharma ***@***.***> wrote:
Hi,
I would like to try and work out this issue. Since I'm a first time
contributor is there anything that I should keep in mind while handling
this?
As of now this is my understanding of the problem -
- Add a template object in the global config object to provide
configuration for templating engine which by default is going to be dotJs
(Eg. ejs/jade)
- Check if each render engine functions properly
Sorry if this approach seems a bit over simplified.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#297 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZyjJX8bQxVJCKWdrnquoXVkIc_YaG-ks5rBquagaJpZM4KgJNU>
.
|
Using the config object changes and the render changes from #292 #291 run a site using ejs and see if there are things that need to be changed.
Also look at whether autodetection of the engine and if there are defaults that make sense if we can autodetect
Part of this ticket should be creating documentation around using ejs and adding examples for how to use ejs with monument
The text was updated successfully, but these errors were encountered: