CI: fix full documentation upload step #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: it seems that using the new version (v4) of upload-artifact adds some upper bound on the number of files to be uploaded. Solution: reverting our actions to use v3 and make changes compatible with other ansys actions, i.e. changing some ansys/action/... to v4 Associated issue : actions/upload-artifact#485
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Samuelopez-ansys
approved these changes
Jan 17, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4089 +/- ##
==========================================
+ Coverage 81.79% 81.85% +0.05%
==========================================
Files 184 184
Lines 63895 63987 +92
==========================================
+ Hits 52266 52377 +111
+ Misses 11629 11610 -19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: it seems that using the new version (v4) of upload-artifact adds some upper bound on the number of files to be uploaded.
Solution: reverting our actions to use v3 and make changes compatible with other ansys actions, i.e. changing some ansys/action/... to v4
Associated issue : actions/upload-artifact#485