MAINT: Bump actions/download-artifact from 3 to 4

[dependabot]

Bumps actions/download-artifact from 3 to 4.

Release notes

Sourced from actions/download-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

ℹ️ However, this is a major update that includes breaking changes. Artifacts created with versions v3 and below are not compatible with the v4 actions. Uploads and downloads must use the same major actions versions. There are also key differences from previous versions that may require updates to your workflows.

For more information, please see:

1. The changelog post.
2. The README.
3. The migration documentation.
4. As well as the underlying npm package, @​actions/artifact documentation.

New Contributors

• @​bflad made their first contribution in actions/download-artifact#194

Full Changelog: actions/download-artifact@v3...v4.0.0

v3.0.2

• Bump @actions/artifact to v1.1.1 - actions/download-artifact#195
• Fixed a bug in Node16 where if an HTTP download finished too quickly (<1ms, e.g. when it's mocked) we attempt to delete a temp file that has not been created yet Migrate dev environment and workflows to node16  actions/toolkit#1278

v3.0.1

• Bump @​actions/core to 1.10.0

Commits

• 6b208ae Merge pull request #274 from actions/vmjoseph/timeout-patch
• 6c5b580 only adding updated license
• 5f5015d readding index
• 1fddaaf Revert "updating licenses"
• 8aa9e21 Revert "updating dist"
• 657edd9 updating licenses
• 555a2fc updating dist
• 4fc4d70 updating lock
• 072ac9d updating version no
• 038dc03 updating version no
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.00%. Comparing base (fd047a7) to head (364e494).
Report is 774 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4096       +/-   ##
===========================================
- Coverage   82.10%   31.00%   -51.10%     
===========================================
  Files         183      183               
  Lines       64464    64464               
===========================================
- Hits        52926    19987    -32939     
- Misses      11538    44477    +32939     

[Samuelopez-ansys]

@MaxJPRey @SMoraisAnsys Not sure if we should update, please check if this could introduce any issue

[SMoraisAnsys]

@Samuelopez-ansys we should avoid to accept this PR for the moment as we had to revert from v4 to v3 too avoid an issue with the number of file we are uploading (cf actions/upload-artifact#485)

[Samuelopez-ansys]

Blocked until documentation build is fixed

[Samuelopez-ansys]

@SMoraisAnsys @MaxJPRey @maxcapodi78

What should we do with these Pull requests?

Not sure if it is going to work, we have to check these 3 updates:

ansys/actions/doc-deploy-stable@v5
actions/upload-artifact@v4
actions/download-artifact@v4

[SMoraisAnsys]

@SMoraisAnsys @MaxJPRey @maxcapodi78

What should we do with these Pull requests?

Not sure if it is going to work, we have to check these 3 updates:

ansys/actions/doc-deploy-stable@v5 actions/upload-artifact@v4 actions/download-artifact@v4

If it bother you, we can close it but I would prefer to leave the 3 PR open as a reminder.
For the moment, we cannot move forward as actions/upload-artifact#485 is still open. More and more people are reverting to the previous version as we did. Hopefuly that will have an impact. Please, consider putting a 👍 on this issue to increase its weight :)

If no fix is proposed soon, I'll try to find some time and look for a bugfix to propose.

[MaxJPRey]

@SMoraisAnsys @MaxJPRey @maxcapodi78
What should we do with these Pull requests?
Not sure if it is going to work, we have to check these 3 updates:
ansys/actions/doc-deploy-stable@v5 actions/upload-artifact@v4 actions/download-artifact@v4

If it bother you, we can close it but I would prefer to leave the 3 PR open as a reminder. For the moment, we cannot move forward as actions/upload-artifact#485 is still open. More and more people are reverting to the previous version as we did. Hopefuly that will have an impact. Please, consider putting a 👍 on this issue to increase its weight :)

If no fix is proposed soon, I'll try to find some time and look for a bugfix to propose.

@SMoraisAnsys I fully agree with you.

[Samuelopez-ansys]

@SMoraisAnsys What should we do with this PR?

[SMoraisAnsys]

@Samuelopez-ansys I'm on days off but I'll see if we can do the associated changes if the CI refactoring.
Part of it seems to be possible when runnings without examples on linux.
However, we can't do that for the one with examples on windows as the issue is still opened.

[pyansys-ci-bot]

Hello @maxcapodi78! This PR was created by dependabot and has not been updated in the last 30 days. Could you please review it?

If you want this repository to be excluded from this automated process, please let us know by filling in the opt-out request form.

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.