Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overriding of DOCKER_IMG_VERSION in Makefile #6468

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix overriding of DOCKER_IMG_VERSION in Makefile #6468

wants to merge 1 commit into from

Conversation

jainpulkit22
Copy link
Contributor

@jainpulkit22 jainpulkit22 commented Jun 20, 2024 •
edited by rajnkamr
Loading

1.Fix overriding of DOCKER_IMG_VERSION in Makefile.
2.Support creating multiple docker bridges to run multiple kind job and to support docker prune for each kind network.
Each kind job should have their kind bridge created and named uniquely.

Refer #6446 for more details

@tnqn
Copy link
Member

tnqn commented Jun 20, 2024

Several tests failed due to the change

@jainpulkit22
Copy link
Contributor Author

Several tests failed due to the change

It is working now.

antoninbas
antoninbas previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Was the original PR introducing support for custom build tags not tested? It feels like such an issue could have been caught with some basic testing.

tnqn
tnqn previously approved these changes Jun 21, 2024
View reviewed changes
@tnqn
Copy link
Member

tnqn commented Jun 21, 2024

Was the original PR introducing support for custom build tags not tested? It feels like such an issue could have been caught with some basic testing.

+1, hope this is the last amendment.

@tnqn
Copy link
Member

tnqn commented Jun 21, 2024

/test-all

@jainpulkit22
Copy link
Contributor Author

jainpulkit22 commented Jun 21, 2024 •
edited
Loading

@KMAnju-2021 can you update the respective builders & test the latest kind jobs here?

@tnqn
Copy link
Member

tnqn commented Jun 21, 2024

@KMAnju-2021 can you test the latest kind jobs here?

@jainpulkit22 can you add some description to #6010 for how to run tests using specific build tag? I wanted to try but didn't find clear docs about it.

@jainpulkit22
Copy link
Contributor Author

jainpulkit22 commented Jun 21, 2024 •
edited
Loading

@KMAnju-2021 can you test the latest kind jobs here?

@jainpulkit22 can you add some description to #6010 for how to run tests using specific build tag? I wanted to try but didn't find clear docs about it.

sure, we just need to provide --build-tag <BUILD_TAG> while invoking the ci/jenkins/test.sh script.

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-only-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-only-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

@jainpulkit22 jainpulkit22 dismissed stale reviews from tnqn and antoninbas via 8a79ef4 June 25, 2024 07:27
@jainpulkit22 jainpulkit22 marked this pull request as draft June 25, 2024 07:27
@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

1 similar comment
@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-only-all

@jainpulkit22
Fix overriding of DOCKER_IMG_VERSION in Makefile
a73cc75 
Signed-off-by: Pulkit Jain <pulkit.jain@broadcom.com>
@jainpulkit22
Copy link
Contributor Author

/test-kind-e2e

1 similar comment
@jainpulkit22
Copy link
Contributor Author

/test-kind-e2e

@rajnkamr rajnkamr added this to the Antrea v2.2 release milestone Jul 15, 2024
@rajnkamr rajnkamr mentioned this pull request Jul 24, 2024
Merged
@rajnkamr rajnkamr mentioned this pull request Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas left review comments

@tnqn tnqn tnqn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Antrea v2.3 release
Development

Successfully merging this pull request may close these issues.
5 participants
@jainpulkit22 @tnqn @KMAnju-2021 @antoninbas @rajnkamr