Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSGO-2 Marshal big int returns variable length slice #1823

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

CASSGO-2 Marshal big int returns variable length slice #1823

wants to merge 1 commit into from

Conversation

OleksiienkoMykyta
Copy link
Contributor

Closes #1740
Currently, gocql supports arbitrary-precision type big.Int, but in Cassandra the bigint is implemented as an eight-byte two's complement integer (see Data Type Serialization Formats).
Fixed this issue in the PR, and added a few tests to cover changes.

@joao-r-reis joao-r-reis changed the title Marshal big int returns variable length slice CASSGO-2 Marshal big int returns variable length slice Oct 29, 2024
@joao-r-reis
Copy link
Contributor

Please squash and format your commit message following the rules stated in CONTRIBUTING.md and add this JIRA to the CHANGELOG.md in the Fixed section of Unreleased, thanks!

We need another committer +1 to merge this.

@OleksiienkoMykyta OleksiienkoMykyta force-pushed the marshalBigInt-returns-variable-length-slice branch from 3ccfdfd to e8a930c Compare November 13, 2024 11:47
@OleksiienkoMykyta
Copy link
Contributor Author

Please squash and format your commit message following the rules stated in CONTRIBUTING.md and add this JIRA to the CHANGELOG.md in the Fixed section of Unreleased, thanks!

We need another committer +1 to merge this.

How could I get one more committer's approval?

@joao-r-reis
Copy link
Contributor

How could I get one more committer's approval?

I've been trying to call out on the #cassandra-drivers ASF slack channel that we need another committer to look at these PRs but so far I haven't been successful. You could try reaching out to committers directly too.

@joao-r-reis
Copy link
Contributor

It looks like some unit tests are failing

@OleksiienkoMykyta
CASSGO-2 Marshal big int returns variable length slice.
a015fbb 
The marshalBigInt return 8 bytes slice in all cases except for big.Int,
which returns a variable length slice, but should be 8 bytes slice as well.

patch by Mykyta Oleksiienko; reviewed by João Reis for CASSGO-2
@OleksiienkoMykyta OleksiienkoMykyta force-pushed the marshalBigInt-returns-variable-length-slice branch from e8a930c to a015fbb Compare November 15, 2024 12:51
@OleksiienkoMykyta
Copy link
Contributor Author

How could I get one more committer's approval?

I've been trying to call out on the #cassandra-drivers ASF slack channel that we need another committer to look at these PRs but so far I haven't been successful. You could try reaching out to committers directly too.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-r-reis joao-r-reis joao-r-reis approved these changes

@taaraora taaraora taaraora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@OleksiienkoMykyta @joao-r-reis @taaraora