-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][CI] Remove rebase check in pr. #15187
Comments
please assign to me. |
Assigned |
I tried using GitHub Action cirrus-actions/rebase@1.8 for implementation. But we can't use the built-in |
We might not need to add action, I find in other projects there is no rebase check, so we might only need to close some setting. |
I think we can use `squash and merge` for merging, and if there are no conflicts, it can automatically squash the commits. If we choose `rebase merging`, it can not squash. cc @zhongjiajie Can we change the setting? |
hi @ruanwenjun the reason we add this is due to this #14530. because we meet some unexpected ci error when we merge multi pr without rebase the latest code |
maybe we can update branch then use squash? |
OK, make sense. |
As @zhongjiajie said, we need to make the pr updated before trigger the ci, then we need to keep, thanks, I will close this issue. |
Search before asking
Description
Right now, we need to rebase the pr to latest dev branch before merged.
If we have 10 pr need to merge, we need to rebase one by one, if there is not conflict, this is not needed.
Are you willing to submit a PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: