Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][CI] Remove rebase check in pr. #15187

Closed
2 of 3 tasks
ruanwenjun opened this issue Nov 19, 2023 · 10 comments
Closed
2 of 3 tasks

[Improvement][CI] Remove rebase check in pr. #15187

ruanwenjun opened this issue Nov 19, 2023 · 10 comments
Assignees
Labels
help wanted Extra attention is needed improvement make more easy to user or prompt friendly wontfix This will not be worked on

Comments

@ruanwenjun
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Right now, we need to rebase the pr to latest dev branch before merged.
image
If we have 10 pr need to merge, we need to rebase one by one, if there is not conflict, this is not needed.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply help wanted Extra attention is needed and removed Waiting for reply Waiting for reply labels Nov 19, 2023
@xjlgod
Copy link
Contributor

xjlgod commented Nov 20, 2023

please assign to me.

@ruanwenjun
Copy link
Member Author

please assign to me.

Assigned

@xjlgod
Copy link
Contributor

xjlgod commented Nov 28, 2023

please assign to me.

Assigned

I tried using GitHub Action cirrus-actions/rebase@1.8 for implementation. But we can't use the built-in secrets.GITHUB_TOKEN because of this limitation, So we need personal token from forked repo(it's difficult to get), and I don't think this is not a good implementation method. Do you have any other suggestions?

@ruanwenjun
Copy link
Member Author

please assign to me.

Assigned

I tried using GitHub Action cirrus-actions/rebase@1.8 for implementation. But we can't use the built-in secrets.GITHUB_TOKEN because of this limitation, So we need personal token from forked repo(it's difficult to get), and I don't think this is not a good implementation method. Do you have any other suggestions?

We might not need to add action, I find in other projects there is no rebase check, so we might only need to close some setting.

@xjlgod
Copy link
Contributor

xjlgod commented Nov 29, 2023

1701231906341

I think we can use squash and merge for merging, and if there are no conflicts, it can automatically squash the commits. If we choose rebase merging, it can not squash.

@ruanwenjun
Copy link
Member Author

1701231906341 I think we can use `squash and merge` for merging, and if there are no conflicts, it can automatically squash the commits. If we choose `rebase merging`, it can not squash.

cc @zhongjiajie Can we change the setting?

@zhongjiajie
Copy link
Member

hi @ruanwenjun the reason we add this is due to this #14530. because we meet some unexpected ci error when we merge multi pr without rebase the latest code

@xjlgod
Copy link
Contributor

xjlgod commented Nov 30, 2023

maybe we can update branch then use squash?

@ruanwenjun
Copy link
Member Author

hi @ruanwenjun the reason we add this is due to this #14530. because we meet some unexpected ci error when we merge multi pr without rebase the latest code

OK, make sense.

@ruanwenjun
Copy link
Member Author

maybe we can update branch then use squash?

As @zhongjiajie said, we need to make the pr updated before trigger the ci, then we need to keep, thanks, I will close this issue.

@zhongjiajie zhongjiajie added the wontfix This will not be worked on label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed improvement make more easy to user or prompt friendly wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants