Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] triple protocol use netty ProtobufEncoder and ProtobufDecoder to replace .proto #14719

Open
4 tasks done
JunJieLiu51520 opened this issue Sep 24, 2024 · 4 comments
Open
4 tasks done
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@JunJieLiu51520
Copy link
Contributor

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

and other way, this can decrease the compiler cost, current sdk repository source is too heavely

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@JunJieLiu51520 JunJieLiu51520 added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Sep 24, 2024
@JunJieLiu51520 JunJieLiu51520 changed the title [Feature] triple protocol use netty ProtobufEncoder and ProtobufDecoder replace .proto to simplyfy develop [Feature] triple protocol use netty ProtobufEncoder and ProtobufDecoder to replace .proto Sep 24, 2024
@JunJieLiu51520
Copy link
Contributor Author

JunJieLiu51520 commented Sep 24, 2024

@oxsean do you agree this ?

@oxsean
Copy link
Collaborator

oxsean commented Sep 25, 2024

Sorry, I didn't quite understand what want to do, can you add more info?

@JunJieLiu51520
Copy link
Contributor Author

JunJieLiu51520 commented Sep 25, 2024

image

i say that if we add a protobuf channelhandler whether mean we need not define .proto file and add (de)serialize logic,

i think it's heavly in dubbo-rpc-triple module, right ?

another reason is dubbo sdk build getting slower and slower and when sync from dubbo to my reponsity always compiler failed

@oxsean
Copy link
Collaborator

oxsean commented Sep 27, 2024

The issue is not on the same level. The ability to encode and decode also relies on having classes generated based on proto. Moreover, Triple is an RPC framework, and its data packets are not in raw proto format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

2 participants