[LIVY-1007]: Livy should not spawn one thread per job to track the job on Kubernetes #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good and it is great that we can ship this with the initial release of Livy with Kubernetes support. If anybody has any objections or code review comments, please let us know before this PR gets merged. Thank you Asif for your contribution! |
nileshrathi345
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of spawning a monitor thread for every session, create a centralised thread to monitor all Kubernetes apps.
JIRA link:https://issues.apache.org/jira/browse/LIVY-1007
How was this patch tested?
Unit Tests: The patch has been verified through comprehensive unit tests.
Manual Testing: Conducted manual testing using Kubernetes on Docker Desktop.
Environment: Helm charts. For detailed instructions on testing using Helm charts, please refer to the documentation available at livycluster.