Replace PL011 generic driver with utilities that can be used by driver developers #13071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driver developers to implement as many or as few PL011 devices as they require.
|
I am not quite sure why the block comments are reported as different lengths; I've verified their lengths are all consistent. I managed to resolve all the other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace PL011 generic driver with utilities that can be used by driver developers to implement as many or as few PL011 devices as they require.
This PR closes #12901
Impact
This change allows boards to re-use the PL011 UART driver implementation in their own drivers but configure as many or as few UART interfaces/devices as they please. It also allows other board-specific configuration logic to have an impact on the PL011 device set up.
Testing
All of the changes were tested for compilation without error, with the exception of the
cxd32xxboard as it has no configuration to initially test.I also tested the QEMU and FVP "boards" in their respective hypervisors using the guides provided in the NuttX documentation to verify that changes to the driver would not break existing functionality. All of the
*:nshdefconfigs for these boards worked.I was unable to test the goldfish implementations (although the changes are the exact same as QEMU) and the cxd32xx board because I do not own the board (nor is there a configuration to test).