Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we provide a potentially larger InternalParquetRecordWriter.getDataSize #3032

Open
dragongu opened this issue Oct 11, 2024 · 1 comment

Comments

@dragongu
Copy link

dragongu commented Oct 11, 2024

The following code currently has getDataSize as an estimated value. The Iceberg rolling file write operation relies on this method, which may result in writing files that are much smaller than expected.

/**
 * @return the total size of data written to the file and buffered in memory
 */
public long getDataSize() {
  return lastRowGroupEndPos + columnStore.getBufferedSize();
}

Could we provide a potentially larger getDataSize? I can't think of any downsides at the moment.

Component(s)

No response

@dragongu dragongu changed the title Confusion in the implementation of InternalParquetRecordWriter Could we provide a potentially larger InternalParquetRecordWriter.getDataSize Oct 11, 2024
@wgtmac
Copy link
Member

wgtmac commented Oct 12, 2024

Do you have any concrete suggestion on what value to provide? My concern is that changing the behavior may affect a lot of downstream applications in the wild without notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants