improve: use ctx and timer instead sleep #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
reviewed
Jul 30, 2024
RobertIndie
reviewed
Jul 31, 2024
nodece
force-pushed
the
user-ctx-timer-instead-sleep
branch
2 times, most recently
from
8d8b6f2
to
d32ac75
Compare
RobertIndie
reviewed
Jul 31, 2024
|
Let me fix the consumer seek test first. |
|
Seek test will be fixed by #1265. |
nodece
force-pushed
the
user-ctx-timer-instead-sleep
branch
from
e307794
to
f7caa08
Compare
nodece
force-pushed
the
user-ctx-timer-instead-sleep
branch
from
f7caa08
to
9904d77
Compare
|
@RobertIndie @crossoverJie Could you have a chance to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are using
time.Sleepandforto execute the retry, which cannot be interrupted, this PR will use context and timer to improve this behavior.The next improvement idea supports passing the context to interrupt the retry, when closing the producer or consumer, we need to do that.
Modifications
Retrymethod to execute the try, and useRetryinstead oftime.Sleepandfor.