From 23b9cb6d1cc3e115867806bb7ee8c49e2da18a6e Mon Sep 17 00:00:00 2001 From: M N Ganesan Date: Fri, 11 Oct 2024 09:17:04 +0000 Subject: [PATCH] [Frontend][ArgParse] Compile with default(LLVM) target and build with BYOC(#17454) It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/optons, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration Signed-off-by: M N Ganesan --- python/tvm/driver/tvmc/target.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/tvm/driver/tvmc/target.py b/python/tvm/driver/tvmc/target.py index 9506ca527ef5..a2d79a184804 100644 --- a/python/tvm/driver/tvmc/target.py +++ b/python/tvm/driver/tvmc/target.py @@ -183,7 +183,7 @@ def validate_targets(parse_targets, additional_target_options=None): if not any([target for target in parse_targets if target["name"] == target_name]): # When built with USE_MRVL=ON, add-on target options are passed from MRVL codegen's # config which has pass_default=True and compiled with default target, don't error - # Use case: --target="llvm" cnn.onnx + # Use case: --target="llvm" cnn.onnx if (len(tvm_targets) == 1) and (target_name == "mrvl"): return