-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB] Move ArtifactCache to Interface, Support Cache delete and Batch Delete, Remove typo #16525
Conversation
please fix the ci errors |
Will re-open after supporting batch delete weights |
23960bd
to
4b55a1b
Compare
Will take a look tomorrow; thank you @DiegoCao! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new interface and deleteInCache()
looks good to me! Thanks for the changes.
I left some comments on deleteNDArrayCache()
, let me know what you think!
7d61b4a
to
4c99370
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good, thank you!
…different cache types, fix README path typo, Support delete and batch delete Co-authored-by: DavidGOrtega <g.ortega.david@gmail.com>
4c99370
to
70911c5
Compare
All issues are resolved, will later pr the corresponding webLLM side API |
Thank you! I think this is ready to be merged cc @tqchen |
Co-authored-by: DavidGOrtega g.ortega.david@gmail.com for parallel download