[Transform] Remove R.Object parameters after LazyTransformParams #16699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
changed the title
Prior to this commit, the output of `relax.transform.LazyTransformParams` would include all parameters that are not `R.Tensor`, in case they defined symbolic variables. However, this added too many unnecessary parameters, such as `R.Object` which cannot define symbolic variables. This commit updates `relax.transform.LazyTransformParams` to only retain `R.Prim` and `R.Shape` parameters, which can define symbolic variables.
Lunderberg
force-pushed
the
relax_lazy_transform_params_object_sinfo
branch
from
11f3c44
to
69995d1
Compare
masahi
approved these changes
Mar 11, 2024
|
@Lunderberg Can you take a look at the failed test? |
|
Failed test should now be resolved. The root issue was in TVMScript parsing, that while a variable could be annotated with an object or tensor class (e.g. |
Lunderberg
force-pushed
the
relax_lazy_transform_params_object_sinfo
branch
from
292c5a2
to
9605bca
Compare
Prior to this commit, bare `StructInfoProxy` annotations could be used to annotate variables (e.g. `var: R.Tensor`). However, they could not be used as the argument of a match cast (e.g. `R.match_cast(obj, R.Tensor)`). This breaks round-trips, as the `R.match_cast` printing generates base `StructInfoProxy` objects. This commit updates TVMScript parsing to handle bare `StructInfoProxy` annotations as an argument to `R.match_cast`.
Lunderberg
force-pushed
the
relax_lazy_transform_params_object_sinfo
branch
from
9605bca
to
94ce183
Compare
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
…che#16699) * [Transform] Remove R.Object parameters after LazyTranformParams Prior to this commit, the output of `relax.transform.LazyTransformParams` would include all parameters that are not `R.Tensor`, in case they defined symbolic variables. However, this added too many unnecessary parameters, such as `R.Object` which cannot define symbolic variables. This commit updates `relax.transform.LazyTransformParams` to only retain `R.Prim` and `R.Shape` parameters, which can define symbolic variables. * [TVMScript][Bugfix] Check for StructInfoProxy in R.match_cast Prior to this commit, bare `StructInfoProxy` annotations could be used to annotate variables (e.g. `var: R.Tensor`). However, they could not be used as the argument of a match cast (e.g. `R.match_cast(obj, R.Tensor)`). This breaks round-trips, as the `R.match_cast` printing generates base `StructInfoProxy` objects. This commit updates TVMScript parsing to handle bare `StructInfoProxy` annotations as an argument to `R.match_cast`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the output of
relax.transform.LazyTransformParamswould include all parameters that are notR.Tensor, in case they defined symbolic variables. However, this added too many unnecessary parameters, such asR.Objectwhich cannot define symbolic variables. This commit updatesrelax.transform.LazyTransformParamsto only retainR.PrimandR.Shapeparameters, which can define symbolic variables.