Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts and Syntax Errors with v3.0 #88

Open
jackwh opened this issue Aug 1, 2019 · 3 comments
Open

Timeouts and Syntax Errors with v3.0 #88

jackwh opened this issue Aug 1, 2019 · 3 comments

Comments

@jackwh
Copy link

jackwh commented Aug 1, 2019

I've just tried to upgrade to v3.0, and found two issues preventing me from upgrading:

  1. The web server times out when making the opcache:compile request, after 30 seconds. Of course this will vary by each server, but to get around it, I'm forced to use ini_set('maximum_execution_time', 0), which I would rather not do. Is there a better fix that can be made within the package itself for this?

  2. My application is using PHP 7.4. When trying to compile the vendor directory, some packages (e.g. symfony/var-dumper) include test cases for PHP 7.4. When a file with PHP 7.4-specific code tries to compile, the command fails with a 500 error.

I tried excluding the paths, but the exclusion didn't seem to make any difference. Even so, when updating packages, it is feasible more PHP 7.4 code could be added at any time.

I would have thought surrounding the optimisation of each individual file in a try/catch might be a suitable fix?

@ovanschie
Copy link
Member

I would have thought surrounding the optimisation of each individual file in a try/catch might be a suitable fix?

it's there.

Maybe this can help you

#90 (comment)

@jackwh
Copy link
Author

jackwh commented Sep 19, 2019

Thanks for your help, adding Tests (case-sensitive T) to the exclusions has fixed point 2.

Point 1 still stands — any thoughts on how to avoid hitting maximum execution time?

@ovanschie
Copy link
Member

ovanschie commented Sep 29, 2019

30 seconds already seems long for most applications, so i'm not sure if we need to set that any higher.

Maybe we can make a config option for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants