Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added parameter and esp-now-midi libraries #5154

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

thomasgeissl
Copy link
Contributor

hey,
this add a parameter library and a midi over esp-now library.

@github-actions github-actions bot added the topic: submission Add library to the list label Sep 24, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/thomasgeissl/ESP-NOW-MIDI

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/thomasgeissl/Parameter:

Linting library in Parameter
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: Invalid category field value utility in library.properties                                            
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             
WARNING: Potentially misspelled examples folder name found: Parameter/example                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD005)                                                                             

Linter results for project: 0 ERRORS, 4 WARNINGS

-------------------

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @thomasgeissl
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@thomasgeissl
Copy link
Contributor Author

dear @ArduinoBot, you are right, i forgot to push my tags to the remote. scusi

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/thomasgeissl/ESP-NOW-MIDI:

Linting library in ESP-NOW-MIDI
INFO: No header file found matching library name (ESP-NOW_MIDI.h). Best practices are for primary header filename to    
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name ESP-NOW MIDI contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format        
         (Rule LP015)                                                                                                  
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: Invalid category field value protocol in library.properties                                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 4 WARNINGS

-------------------

Linting sketch in ESP-NOW-MIDI/examples/receiver

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESP-NOW-MIDI/examples/sender

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 4 WARNINGS

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/thomasgeissl/Parameter:

Linting library in Parameter
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: Invalid category field value utility in library.properties                                            
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             
WARNING: Potentially misspelled examples folder name found: Parameter/example                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD005)                                                                             

Linter results for project: 0 ERRORS, 4 WARNINGS

-------------------

@github-actions github-actions bot merged commit 6b0bcf2 into arduino:main Sep 24, 2024
13 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/thomasgeissl/Parameter/
http://downloads.arduino.cc/libraries/logs/github.com/thomasgeissl/ESP-NOW-MIDI/

github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant