Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning old files and removing unused parameters in tutorials and tests #277

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from

Conversation

nglaser3
Copy link
Contributor

@nglaser3 nglaser3 commented Aug 19, 2024

Changes

Removal of old .txt files used in troubleshooting, and development of moltres
Removal of old script used in prototyping of moltres
Removal of old .md files used for storing information for completed projects / papers
Removal of commented-out parameters and blocks from tests and tutorial input files

Issues

If there are any files that I missed when going through the repository, please mention them!

@nglaser3 nglaser3 requested a review from smpark7 August 19, 2024 16:26
@smpark7
Copy link
Collaborator

smpark7 commented Aug 19, 2024

Thanks for picking this issue up. There's a couple of other files that can be removed too:

  • problems/MoltresNotes.txt
  • problems/residual_data.txt
  • property_file_dir/write...

@nglaser3
Copy link
Contributor Author

I have removed the files you mentioned @smpark7, I am going to expand this PR from just removing old files to also removing commented out parameters and blocks in the tests and examples, issue #118.

@nglaser3 nglaser3 changed the title Cleaning repository of old files no longer relevant Cleaning old files and removing unused parameters in tutorials and tests Aug 19, 2024
@moosebuild
Copy link
Collaborator

Job Test on f5b8e0d : invalidated by @smpark7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of comment cruft in various input files
3 participants