Skip to content

Commit

Permalink
fix(argo-rollouts): Fix of global subscriptions for Argo Rollouts (#2797
Browse files Browse the repository at this point in the history
)

* Fix of Argo Rollouts notifications subscription

Signed-off-by: Yurii Bychenok <bychenok.y@ajax.systems>

* Fixed Argo Rollouts helm changelog

Signed-off-by: Yurii Bychenok <bychenok.y@ajax.systems>

* Fixed Argo Rollouts helm default values.yaml

Signed-off-by: Yurii Bychenok <bychenok.y@ajax.systems>

* Fixed Argo Rollouts doc after helm update

Signed-off-by: Yurii Bychenok <bychenok.y@ajax.systems>

---------

Signed-off-by: Yurii Bychenok <bychenok.y@ajax.systems>
Signed-off-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
  • Loading branch information
ajax-bychenok-y and yu-croco committed Jun 26, 2024
1 parent 3d98d04 commit 425e98e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions charts/argo-rollouts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v1.7.1
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.37.0
version: 2.37.1
home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
keywords:
Expand All @@ -18,5 +18,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Bump argo-rollouts to v1.7.1
- kind: fixed
description: Fix subscriptions into notifications-configmap
2 changes: 1 addition & 1 deletion charts/argo-rollouts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ For full list of changes please check ArtifactHub [changelog].
| notifications.secret.annotations | object | `{}` | Annotations to be added to the notifications secret |
| notifications.secret.create | bool | `false` | Whether to create notifications secret |
| notifications.secret.items | object | `{}` | Generic key:value pairs to be inserted into the notifications secret |
| notifications.subscriptions | object | `{}` | The subscriptions define the subscriptions to the triggers in a general way for all rollouts |
| notifications.subscriptions | list | `[]` | The subscriptions define the subscriptions to the triggers in a general way for all rollouts |
| notifications.templates | object | `{}` | Notification templates |
| notifications.triggers | object | `{}` | The trigger defines the condition when the notification should be sent |
| providerRBAC.additionalRules | list | `[]` | Additional RBAC rules for others providers |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ data:
{{- toYaml . | nindent 2 }}
{{- end }}
{{- with .Values.notifications.subscriptions }}
subscriptions:
subscriptions: |
{{- toYaml . | nindent 4 }}
{{- end }}
10 changes: 5 additions & 5 deletions charts/argo-rollouts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -482,9 +482,9 @@ notifications:
# when: rollout.spec.template.spec.containers[0].image == 'argoproj/rollouts-demo:purple'

# -- The subscriptions define the subscriptions to the triggers in a general way for all rollouts
subscriptions: {}
# subscriptions:
# recipients:
# - slack:<channel>
subscriptions: []
# - recipients:
# - slack:<channel>
# triggers:
# - on-rollout-completed
# - on-rollout-completed
# - on-rollout-aborted

0 comments on commit 425e98e

Please sign in to comment.