Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

didTapTarget Incorrectly false for UITableViewCell #113

Open
poisondminds opened this issue Oct 4, 2019 · 3 comments
Open

didTapTarget Incorrectly false for UITableViewCell #113

poisondminds opened this issue Oct 4, 2019 · 3 comments
Assignees
@tdle94

Comments

@poisondminds
Copy link

It seems that the delegate's showCaseDidDismiss?(showcase: didTapTarget:) is incorrectly false when dismissing the showcase by tapping the target cell.
@tdle94 tdle94 self-assigned this Oct 7, 2019
tdle94 pushed a commit that referenced this issue Nov 5, 2019
fix issue #113. Where didTapTarget is false on the target cell
fca6543
@tdle94
Copy link
Contributor

tdle94 commented Nov 5, 2019

Can you pull from master and try again. I fix the issue

@tdle94 tdle94 closed this as completed Nov 5, 2019
@poisondminds
Copy link
Author

@tdle94 it seems that your commit caused several problems - isTapRecognizerForTargetView no longer functions properly. Play with the flag in the sample app and you'll see what's broken

isTapRecognizerForTargetView set to false no longer functions as it should. When this is set to false, the showcase should dismiss when you tap outside of the target

@quangctkm9207 quangctkm9207 reopened this Nov 6, 2019
@quangctkm9207
Copy link
Collaborator

I just reverted to the previous commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdle94 tdle94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quangctkm9207 @tdle94 @poisondminds