Adds username resolution across the dapp #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-toth
requested changes
Oct 27, 2023
pages/[profile]/[slugOrId].vue
Outdated
| @@ -129,16 +129,16 @@ | |||
| > | |||
| <nuxt-link | |||
| class="font-italic text-primary" | |||
| :to="`/${ artwork.creator }`" | |||
| :to="`/${ artwork.username }`" | |||
There was a problem hiding this comment.
not everyone has an art by city username and it isn't a requirement. also, this could be any type of username or blockchain address in the future (i.e. ANS, ARK).
still, if they have a username the url should use the username, but if not should use their address
jim-toth
approved these changes
Oct 31, 2023
jim-toth
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.