Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.1 #66

Open
jayvdb opened this issue Apr 18, 2019 · 2 comments
Open

Django 2.1 #66

jayvdb opened this issue Apr 18, 2019 · 2 comments

Comments

@jayvdb
Copy link

jayvdb commented Apr 18, 2019

Tests fail with

  File "/home/abuild/rpmbuild/BUILD/django-compat-1.0.15/compat/tests/urls.py", line 5, in <module>
    url(r'^accounts/logout/$', views.logout, name='logout'),
AttributeError: module 'django.contrib.auth.views' has no attribute 'logout'

Fairly simple to fix https://stackoverflow.com/questions/47065438/attributeerror-module-django-contrib-auth-views-has-no-attribute

@jayvdb
Copy link
Author

jayvdb commented Apr 18, 2019

Also running the tests on Django 2.2 results in

[  217s] ERRORS:
[  217s] ?: (admin.E404) 'django.contrib.messages.context_processors.messages' must be enabled in DjangoTemplates (TEMPLATES) in order to use the admin application.
[  217s] ?: (admin.E406) 'django.contrib.messages' must be in INSTALLED_APPS in order to use the admin application.
[  217s] ?: (admin.E407) 'django.contrib.sessions' must be in INSTALLED_APPS in order to use the admin application.
[  217s] ?: (admin.E408) 'django.contrib.auth.middleware.AuthenticationMiddleware' must be in MIDDLEWARE in order to use the admin application.
[  217s] ?: (admin.E409) 'django.contrib.messages.middleware.MessageMiddleware' must be in MIDDLEWARE in order to use the admin application.

@jayvdb
Copy link
Author

jayvdb commented May 7, 2019

fwiw, pakal/django-compat-patcher#2 was fixed, so it is probably possible to use that patcher to fix this codebase to make it work with Django 2 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant