Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-bind with class should not clobber the agility class of root element #107

Open
cdrubin opened this issue Sep 5, 2013 · 2 comments
Open

Comments

@cdrubin
Copy link

cdrubin commented Sep 5, 2013

First-off: Thank you for a great framework! :)

var $$item = $$( {
  model: {
    type: 'document' 
  }, 
  view: { 
    'format': '<li data-bind="name, class=type">', 
    'style': '& { background-color: green }'
  } 
} );

should result in this HTML :

<li class=".agility_X document" data-bind="name, class=type"></li>

but instead clobbers the .agility_X class and results in :

<li class="document" data-bind="name, class=type"></li>
@cdrubin
Copy link
Author

cdrubin commented Sep 16, 2013

I see even more clobbering happening:

var $$item = $$( {
  model: {
    button_text: 'submit' 
  }, 
  view: { 
    'format': '<a data-bind="button_text"><img src="something.png" /></a>'
  } 
} );

should result in the HTML :

<a data-bind="button_text"><img src="something.png" />submit</a>

but instead clobbers the child element and results in :

<a data-bind="button_text">submit</a>

Is this intentional? Same for the first issue, is this somehow desirable and I am missing the purpose?

@robertjustjones
Copy link
Collaborator

@cdrubin, yes, I believe this second example is intentional. Try moving the data-bind to a <span> inside the <a>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants