Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] in the example workflow #60

Closed
miasik opened this issue Sep 22, 2024 · 6 comments
Closed

[BUG] in the example workflow #60

miasik opened this issue Sep 22, 2024 · 6 comments

Comments

@miasik
Copy link

miasik commented Sep 22, 2024

Could you please review your example https://github.com/asagi4/comfyui-prompt-control/blob/master/workflows/example.json?raw=1
I see "PCApplySettings" is not connected
As I understand it has to be connected both to "ScheduleToCond" and "ScheduleToModel"

изображение

@asagi4
Copy link
Owner

asagi4 commented Sep 22, 2024

Huh. Well, I'll fix that at some point.

@miasik
Copy link
Author

miasik commented Sep 22, 2024

Huh. Well, I'll fix that at some point.

Also, please, add "PCSplitSampling" to the example

@miasik
Copy link
Author

miasik commented Sep 23, 2024

I've finally managed to properly connect "PCSplitSampling" but I also found an incompatibility with some "ComfyUI-Impact-Pack" nodes:
ltdrdata/ComfyUI-Impact-Pack#751

@asagi4
Copy link
Owner

asagi4 commented Sep 23, 2024

I redid the example workflow. I removed some of the more obscure features from it but added eg. custom mask usage.

@miasik
Copy link
Author

miasik commented Sep 23, 2024

I redid the example workflow. I removed some of the more obscure features from it but added eg. custom mask usage.

I see "PCSplitSampling" right after "Load Checkpoint". Don't I have to place it at exactly before KSampler?

@asagi4
Copy link
Owner

asagi4 commented Sep 24, 2024

@miasik I'm pretty sure it should work in either position since all it does is set a flag in model_options

@miasik miasik closed this as completed Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants