-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve syntax highlighting using a Language Server Protocol implementation #686
Comments
It's worth noting that semantic tokens do not support embedded languages: In other words, source blocks won't be properly highlighted in AsciiDoc. I don't think we should adopt the semantic tokens feature until embedded languages are supported. I guess our only solution right now is to use LSP. |
Is this basically the same issue as #625 ? |
Looking into LSP has been on my ToDo list for a long time. This issue might be somethIng to get this action item checked off. Wondering though if it might be better to have a dedicated project for that as a LSP implementation (e.g. |
@ViToni If you want to work on it that would be awesome! Yes, we should create a dedicated project! In case you've missed it, the AsciiDoc specification is under way:
The current syntax highlighter is broken and we could do so much more with a proper LSP (suggestion, lint, reformat and so on) |
@ggrossetie I'd try to get my feets wet. Not sure how far I get, but at least I'd like to give it a try. |
Related to: asciidoctor/asciidoctor#3630 |
We currently rely on a TextMate grammar but it cannot properly parse AsciiDoc.
I think we should migrate to semantic highlighting: code.visualstudio.com/api/language-extensions/semantic-highlight-guide or LSP: code.visualstudio.com/api/language-extensions/language-server-extension-guide
If someone wants to give it a try, please feel free to do so!
Related issues:
]
#375|==
) #894The text was updated successfully, but these errors were encountered: