feat: Add messages for bulk install visibility #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StingRayZA
force-pushed
the
stingrayza/verbose-batch-install
branch
from
45258a0
to
83e00a9
Compare
StingRayZA
changed the title
|
@jthegedus apologies for the direct ping, any chance of getting a review, here, please? |
|
Some test cases will likely need to be updated. The Fish issue is unrelated and one I need to resolve. |
|
Thanks @jthegedus |
StingRayZA
force-pushed
the
stingrayza/verbose-batch-install
branch
from
ad4e81c
to
c402245
Compare
|
@jthegedus Tests updated (I've rebased my branch on the upstream I wasn't able to figure out how to do a multiline match, so I've matched on partial strings. I did add a specific test to separately check for these particular outputs. |
Add downloading and installing messages Signed-off-by: Raimund Hook <rhook@gitlab.com>
StingRayZA
force-pushed
the
stingrayza/verbose-batch-install
branch
from
c402245
to
f31c639
Compare
|
nudging this gently :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a progress message mentioning that a package is being downloaded and installed. Useful when bulk installing tools to know what is actively happening.
Fixes: #1753
Other Information