Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying too slow #11

Open
Spiegel-Leser opened this issue Mar 9, 2021 · 1 comment
Open

Copying too slow #11

Spiegel-Leser opened this issue Mar 9, 2021 · 1 comment

Comments

@Spiegel-Leser
Copy link

I accidentally backupped to a new folder, so all files are copied. This takes 5 hours exactly. When copying all files with robocopy, it takes ~30 minutes. So copying is much slower than strictly necessary.

Idea: If it's too difficult making your algorithm more efficient you could let it do all the hardlinks and then copy the remaining files with robocopy.

@asdfjkl
Copy link
Owner

asdfjkl commented Mar 9, 2021

I'll have a look, won't promise anything.

Background:
Currently using C# File.Copy which itself is a wrapper for Win32's CopyFile. Not impossible, but difficult to accelerate, cf. https://stackoverflow.com/questions/1246899/file-copy-vs-manual-filestream-write-for-copying-file/1247042#1247042

using robocopy is maybe an option, but unlikely - controlling and using an external process is difficult. Not in the case where everything works well, but for the case when there is an unexpected error... When in doubt, reliability and deterministic behaviour is always preferred to speed ... for a backup program...

I'll always accept well written merge requests of course :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants