Building a HB template with $CLASS$ text fails

[jonschlinkert]

moved from assemble/assemble#580 (comment)

[knight-dj-et]

https://github.com/assemble/grunt-assemble/blob/master/tasks/assemble.js#L700

1 line change

change layout.replace(assemble.engine.bodyRegex, body); to layout.replace(assemble.engine.bodyRegex, body.replace("$", "$$$$"));

[doowb]

@jonschlinkert's solution with .split().join() is probably a better way to go. The other way is to use function () { return body; } instead of body, but I think Jon's benchmarked the split/join and it's usually faster, right?

@knight-dj-et if you'd like to do a PR, that'd be awesome!

[jonschlinkert]

I think Jon's benchmarked the split/join and it's usually faster, right?

well, it's not about faster here. it's only useful if we want to replace multiple occurrences of body, which I 'm almost positive we were doing - at least at one point. I remember the pr that added that. If not, then we can't do split.

[jonschlinkert]

but yes, it's also considerably faster

[jonschlinkert]

wait, why would we do layout.replace(assemble.engine.bodyRegex, body.replace("$", "$$$$"));. that will arbitrarily replace the first $ character anywhere in the body string with $$$$.

[knight-dj-et]

Oh. I suppose I did it too broadly. It should replace any $ followed by a $, ', `, & or number with "$$" (which has to be passed as "$$$$" since this is using replace which will still treat the $ as special characters)

[jonschlinkert]

we would need to do something like this:

var injectBody = function(layout, body) {
  body = body.split('$').join('___ESC_DOLLAR__');
  var res = layout.replace(assemble.engine.bodyRegex, body);
  return res.split('___ESC_DOLLAR__').join('$');
};

edited...

[jonschlinkert]

the other alternative is to just do split/join on the actual body tag. IMO that's a better way to go. since : 1) a user would expect any tag to yield the same result if it was used more than once in a string, 2) it would only do the split/join operation once, whereas the escaping approach ends up doing it three times (including .replace())

[doowb]

All we need to do is layout.replace(assemble.engine.bodyRegex, function () { return body; });

[jonschlinkert]

^ what he said lol

[jonschlinkert]

@doowb you said that earlier and I missed the function part of the replacement...

[doowb]

fixed in grunt-assemble@0.3.1