Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

A few bugs to look into (binoc or lookout?) #14

Open
vsoch opened this issue Sep 17, 2021 · 1 comment
Open

A few bugs to look into (binoc or lookout?) #14

vsoch opened this issue Sep 17, 2021 · 1 comment

Comments

@vsoch
Copy link
Contributor

vsoch commented Sep 17, 2021

Just want to consolidate these here!

  • When binoc runs an update from upstream, sometimes the content of the PR is empty and labeled docs. Ideally binoc wouldn't open a PR if there aren't changes.
  • Also when binoc runs an update and I think a regular update for a version, sometimes the entire set of versions are repeated (e.g., recent singularity update)
  • If a version has deprecated=True or an extension=, binoc seems to remove them.
@alecbcs
Copy link
Contributor

alecbcs commented Sep 17, 2021

When binoc runs an update from upstream, sometimes the content of the PR is empty and labeled docs. Ideally binoc wouldn't open a PR if there aren't changes.

Haha yeah this on my list to fix. I believe it's because it's seeing the commit within Spack is newer than in Autamus and assuming something has changed. Adding a check for this isn't as easy as I'd hopped but I should be doable over the weekend. Just a little refactoring.

Also when binoc runs an update and I think a regular update for a version, sometimes the entire set of versions are repeated (e.g., recent singularity update)

Yeah this is a go-parspack bug which is on my list. It's occurs when the versions are split up with a space and I was just doing a find and replace all.

If a version has deprecated=True or an extension=, binoc seems to remove them.

Ahh yep I'll need to tell go-parspack that both of those are legal flags for a version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants