Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Jinja Error #8

Open
allamand opened this issue May 5, 2023 · 1 comment
Open

Test Jinja Error #8

allamand opened this issue May 5, 2023 · 1 comment

Comments

@allamand
Copy link

allamand commented May 5, 2023

Hello,

In the https://catalog.workshops.aws/proton/en-US/module-1/services/define-the-service-instance-infrastructure part of test jinja, you don't show the expected results when running the script, and it fails on my side:

python3 -m unittest discover -s .

E
======================================================================
ERROR: test_jinja (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_jinja
Traceback (most recent call last):
  File "/home/linuxbrew/.linuxbrew/opt/python@3.10/lib/python3.10/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/home/linuxbrew/.linuxbrew/opt/python@3.10/lib/python3.10/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/ubuntu/environment/proton/aws-proton-workshop/test_jinja.py", line 13, in <module>
    class TestJinja(unittest.TestCase):
  File "/home/ubuntu/environment/proton/aws-proton-workshop/test_jinja.py", line 21, in TestJinja
    conf = YamlLintConfig('{\
  File "/home/ubuntu/environment/proton/aws-proton-workshop/venv/lib/python3.10/site-packages/yamllint/config.py", line 45, in __init__
    self.validate()
  File "/home/ubuntu/environment/proton/aws-proton-workshop/venv/lib/python3.10/site-packages/yamllint/config.py", line 148, in validate
    self.rules[id] = validate_rule_conf(rule, self.rules[id])
  File "/home/ubuntu/environment/proton/aws-proton-workshop/venv/lib/python3.10/site-packages/yamllint/config.py", line 189, in validate_rule_conf
    raise YamlLintConfigError(
yamllint.config.YamlLintConfigError: invalid config: option "spaces" of "indentation" should be in (<class 'int'>, 'consistent')


----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)
moralesl added a commit to moralesl/aws-proton-workshop-code that referenced this issue Jul 27, 2023
moralesl added a commit to moralesl/aws-proton-workshop-code-template that referenced this issue Jul 27, 2023
This is one of the issues, that lead to aws-samples#8
@moralesl
Copy link
Contributor

Hey @allamand,
I've updated the workshop resources and the CF template, so now it should work.
If you find the time, could verify this as well?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants