Force Lambda failure #558
Open
Force Lambda failure #558
+86
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the new feature of configurable error status codes via the `AWS_LWA_ERROR_STATUS_CODES` environment variable, with support for both individual codes and ranges. Key points about the implementation: 1. Backward compatibility is maintained 2. Supports comma-separated status codes and ranges 3. Gracefully handles invalid input 4. Added parsing and testing for status code parsing 5. Integrated into the existing `fetch_response` method The code is ready to be committed. Would you like me to generate a commit message for these changes?
DiscreteTom
reviewed
Dec 17, 2024
| return (start..=end).collect::<Vec<_>>(); | ||
| } | ||
| } | ||
| vec![] |
There was a problem hiding this comment.
Maybe better to print a warning if the env var format is incorrect.
| } | ||
| vec![] | ||
| } else { | ||
| part.parse::<u16>().map_or(vec![], |code| vec![code]) |
There was a problem hiding this comment.
Same as the above, suggest to add a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
close #555 #537
Description of changes:
Add
AWS_LWA_ERROR_STATUS_CODESenvironment variable, to allow developers to force Lambda failure.A comma-separated list of HTTP status codes that will cause Lambda invocations to fail. Supports individual codes and ranges (e.g. "500,502-504,422"). When the web application returns any of these status codes, the Lambda invocation will fail and trigger error handling behaviors like retries or DLQ processing. This is useful for treating certain HTTP errors as Lambda execution failures. This feature is disabled by default.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.