-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Improve folder structure #417
Comments
👍 100% agree What do you think about moving test files next to their source? .
├── rules/
│ ├── sort-classes/
│ │ ├── some-class-utility.ts
│ │ ├── types.ts
│ │ └── types.test.ts
│ ├── sort-imports/
│ │ ├── detect-import-type.ts
│ │ └── detect-import-type.test.ts
│ ├── sort-classes.ts
│ ├── sort-classes.test.ts
│ ├── sort-imports.ts
│ ├── sort-imports.test.ts
│ ├── sort-exports.ts
│ └── sort-exports.test.ts
└── utils/
├── compare.ts
└── compare.test.ts |
@hugop95 I don't know, I think it would be cleaner if the tests were kept in a separate folder. What do you think? |
@azat-io I think there are pros and cons with each. Ultimately though, it's really a matter of personal preference. Pros of having tests next to their source code
Cons
|
I just feel like there would be too many files in the rules folder and it would be a little harder to navigate if I wanted to read only the tests or only the source code of the rules. Personally, I prefer a separate folder for tests. I would like to hear other opinions. |
We currently have a mess of files in the
utils
folder.I think we should clean up this folder and move utilities to folders related to rules:
Common utilities should remain in the
utils
folder.The text was updated successfully, but these errors were encountered: