Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add [PUB] downloads badge #10745

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add [PUB] downloads badge #10745

wants to merge 5 commits into from

Conversation

G1Joshi
Copy link
Contributor

@G1Joshi G1Joshi commented Dec 14, 2024

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @G1Joshi!

Generated by 🚫 dangerJS against ce806ec

PyvesB
PyvesB reviewed Dec 15, 2024
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @G1Joshi! A few comments online, but overall this is good work! 👍🏻

services/pub/pub-downloads.service.js Outdated Show resolved Hide resolved
services/pub/pub-downloads.service.js Outdated Show resolved Hide resolved
services/pub/pub-downloads.service.js Outdated Show resolved Hide resolved
services/pub/pub-downloads.service.js Outdated Show resolved Hide resolved
@G1Joshi G1Joshi requested review from PyvesB and chris48s December 16, 2024 08:11
PyvesB
PyvesB reviewed Dec 16, 2024
View reviewed changes
services/pub/pub-downloads.service.js
return renderDownloadsBadge({
downloads: downloadCount30Days,
interval: 'month',
colorOverride: 'blue',
Copy link
Member

@PyvesB PyvesB Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for needing a color override?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pub focuses on Dart/Flutter, with blue as a key element of its brand identity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB left review comments

@chris48s chris48s Awaiting requested review from chris48s

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add [PUB] downloads badge
3 participants
@G1Joshi @chris48s @PyvesB